refactor(features): rename runtimeFlags to lwcRuntimeFlags #3004
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
In our build artifacts for
engine-dom
andengine-server
, I would like to be able to replace runtime flags withtrue
andfalse
for tree-shaking purposes. (I.e. a consumer can tree-shake out any runtime features they are not using.)This is possible today with e.g.
@rollup/plugin-replace
, but currently our build artifacts contain things like:... which would require:
I propose renaming
runtimeFlags
to the more explicitlwcRuntimeFlags
, because:runtimeFlags
.So we would have:
and:
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item